Record: Variable structure
Single was used as identifier in a set! This is not recommended in Pascal. So I changed all identifiers in set 'maritalStates' to be prefixed with 'ms_'.
Response from User:Kai_Burghardt for undoing this change:
keep it simple [and Pascal does not define “single”, so there’s no reason not to name an identifier like that]
- Take a look at Record#Variable_structure and you notice that
singleis colored red. So this item has a meaning in pascal formatting. This is not good in an example, because noone should wonder why a maritalState is related to ObjectPascal.
- Take a look at Data_type#Floating-point_types: in freepascal
realis platform dependent. I would not recommend to use it. In the whole unit math you wouldn't find any
Singleis defined in fpc/3.0.4/source/rtl/win64/system.pp according to Lazarus hint, although you are free to redefine it as it is done here. Also not good in an example. And then you should at least mention it.
- If you paste the example in a new application and define somewhere: the user gets:
Income : Single;
Error in type definition. Why would you introduce a source of unexplainable errors to new users?
- Also it's good practice to prefix your enumerated type identifiers like:
bsSolid, vk_Escape, pf32bit. Why not show good programming style to new users?
- There is nothing simple in not using the last mentioned point. Instead, this would improve the readibility of the code - that is simple.