Talk:ISO 7064

From Lazarus wiki
Revision as of 00:58, 3 December 2021 by Kai Burghardt (talk | contribs) (→‎Not stable code: add comment)
Jump to navigationJump to search

Not stable code

Because of 'isx := StrToInt( sx );', the code fails on any non-digit string. It's bad. Alextp (talk) 19:32, 28 November 2021 (CET)

Most likely it is supposed to fail if any of the chars is NOT a digit. Having it fail with an exception is not worse than having it fail in some other way (e.g. setting resukt to -MaxInt, having an out paramter indicating succes or do it like the many TryStrtoYYY conversion routines we have), as long as that behaviour is documented.--Bart (talk) 23:39, 28 November 2021 (CET)
Documented now.--Bart (talk) 23:42, 28 November 2021 (CET)

@Alextp. IMO the page is a bit useless now after your last edits. --Bart (talk) 21:34, 2 December 2021 (CET)

You might as well delete this page considering it was essentially only referenced by the IBAN page (cf. Special: WhatLinksHere/ISO 7064). I mean, it’s unlikely anyone’s looking for exactly this page in this wiki. If its content were expanded significantly, I’d keep it though. Kai Burghardt (talk) 23:58, 2 December 2021 (CET)